Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master branch into gh-pages and close master #406

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from

Conversation

richardwestenra
Copy link
Member

The master branch is 3 commits ahead (and 345 commits behind) gh-pages, because #389 was, I presume, accidentally(?) merged into master instead of gh-pages. Once this PR/branch is merged into gh-pages, we can delete this branch, which will hopefully prevent similar confusion in the future.

image

stampycode and others added 3 commits March 20, 2018 19:32
Difference between "We will be styling this page"
at https://github.com/codebar/tutorials/blob/master/html/lesson2/tutorial.md#today-we-will-be-focusing-on-fundamental-css-concepts
and "Download the files required to begin working through the tutorial from here(mac/linux) or here(windows)"
at https://gist.github.com/hundred/7332441/download
missing class from the tutorial example
@taw
Copy link
Contributor

taw commented Oct 18, 2018

If you only have one branch anyway, you can configure it to deploy from master.

@richardwestenra
Copy link
Member Author

@taw I agree and that's what I would have done when setting up this repo, but it's done now, and there are 15 active PRs into gh-pages, and it doesn't really matter anyway, so for now I think the best approach is to delete master. If we ever clear out all the active PRs then we can look into switching the default branch back to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants