Some copy amends based on feedback from a marketing person #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimberleyCook
force-pushed
the
update-copy-from-feedback
branch
4 times, most recently
from
76df394
to
99f3fc9
Compare
KimberleyCook
force-pushed
the
update-copy-from-feedback
branch
from
99f3fc9
to
8ddcf5e
Compare
| @@ -19,7 +19,7 @@ | |||
| - if logged_in? | |||
| = render partial: 'subscriptions' | |||
| - else | |||
| = link_to 'Sign up', new_member_path, class: 'btn btn-primary' | |||
| = link_to 'Join our community', new_member_path, class: 'btn btn-primary' | |||
There was a problem hiding this comment.
@KimberleyCook should we standardize on either 'Join our community' or 'Join the codebar community'? We also have a translation string for this on line 336 of config/locales/en.yml, can we use that here as well?
| @@ -7,7 +7,7 @@ | |||
| .container.d-flex | |||
| .col-md-5.offset-md-1.p-3.text | |||
| %p.lead.mb-0= raw t('homepage.intro') | |||
| = link_to ('Sign up'), new_member_path, class: 'btn btn-primary btn-lg mt-4' | |||
| = link_to ('Join the codebar community'), new_member_path, class: 'btn btn-primary btn-lg mt-4' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.