Add multiple search fields #810
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tudoramariei is attempting to deploy a commit to the Code for Romania Team on Vercel. A member of the Team first needs to authorize it. |
tudoramariei
force-pushed
the
search_revamp
branch
2 times, most recently
from
54b19a3
to
08976ed
Compare
tudoramariei
force-pushed
the
search_revamp
branch
from
08976ed
to
f53b97b
Compare
| .filter( | ||
| similarity__gt=settings.TRIGRAM_SIMILARITY_THRESHOLD, | ||
| Q(rank__gte=settings.SEARCH_RANKING_THRESHOLD) |
There was a problem hiding this comment.
should we pull this in a separate method ?
| @@ -184,7 +184,8 @@ | |||
| "DEFAULT_SCHEMA_CLASS": "drf_spectacular.openapi.AutoSchema", | |||
| } | |||
|
|
|||
| TRIGRAM_SIMILARITY_THRESHOLD = 0.1 | |||
| SEARCH_RANKING_THRESHOLD = 0.4 | |||
| TRIGRAM_SIMILARITY_THRESHOLD = 0.3 | |||
There was a problem hiding this comment.
how are these numbers obtained ? empirical ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the way buildings are searched