New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate models to new city model #368
Open
aramboi
wants to merge
13
commits into
code4romania:develop
Choose a base branch
from
aramboi:migrate-models-to-new-city-model
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate models to new city model #368
aramboi
wants to merge
13
commits into
code4romania:develop
from
aramboi:migrate-models-to-new-city-model
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramboi
requested review from
andreiio,
aniri,
catileptic,
costibleotu,
RaduCStefanescu and
vtemian
as code owners
May 8, 2020 10:42
The city autocomplete will require a county parameter to return the cities only found in that county. Fixed dropdown selection on the front page to use the new city model properly.
aramboi
commented
May 20, 2020
Closed
aramboi
changed the title
WIP: Migrate models to new city model
Migrate models to new city model
May 22, 2020
This PR is ready for review and merge. |
aramboi
commented
May 23, 2020
@@ -1,25 +0,0 @@ | |||
document.addEventListener('DOMContentLoaded', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was moved in main.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it fix?
This is part 2 of the #327 issue and contains the migration that will link the current NGO models to the new City model. This has to be deployed after this commit is deployed 2608adf and the list of cities is imported using the admin interface.
How has it been tested?
develop
branch./manage.py migrate