Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a conf toggle so sponsors->prospectus in nav #18

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

phette23
Copy link
Member

@phette23 phette23 commented Oct 25, 2023

Sets the toggle to true so this takes effect right away. I debated if we should rename the menu link to "Prospectus" but I actually think it's better / clearer to leave it as "Sponsors", though that's debatable.

@triplingual
Copy link
Collaborator

@phette23 Is this PR moot at this point?

@phette23
Copy link
Member Author

It's irrelevant for this year now but it'd be useful for future years. If you look at the progress of sponsorships:

  1. We have no sponsors <--- useful here, /sponsors/ links to prospectus instead of an empty sponsors page
  2. We have some sponsors — we want to show the sponsors page & it links to prospectus (current state)
  3. We're no longer accepting sponsors — no need to link to prospectus, site.data.conf.sponsor-buttons: false

@triplingual
Copy link
Collaborator

Ah, understood. Would it be risky to merge it now? Do you want to wait until after the conference for any other reason?
Probably just my slightly compulsive but irregularly present desire for neatness kicking in.

@phette23
Copy link
Member Author

I don't think there's any harm but I added a commit just now so sponsors-links-to-prospectus is false.

@phette23 phette23 merged commit d53c4be into main May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants