Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Testing for the Existence of Config Data, Use != nil #8

Open
dzoladz opened this issue Oct 20, 2021 · 2 comments
Open

When Testing for the Existence of Config Data, Use != nil #8

dzoladz opened this issue Oct 20, 2021 · 2 comments
Assignees

Comments

@dzoladz
Copy link
Member

dzoladz commented Oct 20, 2021

Per @phette23

use != nil instead of != '' to test if config data exists

Here's a comment that discusses the boolean logic of these values

We'll need to globally find and replace these tests, carefully and perhaps selectively at first. There are likely associated updates that will need to be made to configuration and data files. See PR #7 for and example.

phette23 added a commit that referenced this issue Oct 22, 2021
also edit a few if conditions to use `!= nil`, ref #8
@kaitlinnewson
Copy link
Member

Could the preferred way to handle empty variables in the config and templates also be added to the style guide? This would be helpful to ensure we remain consistent going forward.

@dzoladz
Copy link
Member Author

dzoladz commented Nov 8, 2021

@ranti Would you be able to find an appropriate place in the above referenced style guide to add this info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants