Generate pyodide assets without hashes in the filename #58548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadPyodide()
hardcodes a list of path-names in JS to load from HTTP, which won't work if Rails modifies the filename to output to thedashboard/public/assets/js/pyodide/**
to include a hash.This PR adds the non-digest-assets Gem to control which assets are output without hashes in the filenames.
After this PR,
RAILS_ENV=development bundle exec rake assets:precompile
produces output both with and without hashes, like so:Generating both with/without the filename hash does double the size of the pyodide assets directory, but this doesn't seem like a big deal because its only adding 65MB atm and assets is already 4G or so.
Can test with: http://localhost-studio.code.org:3000//s/allthethings/lessons/50/levels/1
An alternative approach to the problem is here: #58547