Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Web session management PLUTO-883 #2062

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

claudiacarpinteiro
Copy link
Contributor

@claudiacarpinteiro claudiacarpinteiro commented Mar 18, 2024

Adds a page describing the expiration timeouts set by Codacy for every session.

馃憖 Live preview

https://pluto-883-app-session-management--docs-codacy.netlify.app/account/user-session-management/

馃毀 To do

  • Solve TODO
  • Request validation
  • Apply feedback
  • Wait for feature release
  • Remove don't merge label before merging

@claudiacarpinteiro claudiacarpinteiro self-assigned this Mar 18, 2024
@claudiacarpinteiro claudiacarpinteiro added the don't merge Don't merge this pull request yet label Mar 18, 2024
Copy link
Contributor

github-actions bot commented Mar 18, 2024

Overall readability score: 53.85 (馃煝 +0.02)

File Readability
user-session-management.md 57.47 (-)
View detailed metrics

馃煝 - Shows an increase in readability
馃敶 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
user-session-management.md 57.47 36.69 11.58 10.4 10.15 8.09
- - - - - -

Averages:

Readability FRE GF ARI CLI DCRS
Average 53.85 42.52 10.9 12.44 12.55 7.91
馃煝 +0.02 馃敶 -0.03 馃煝 +0 馃煝 +0.01 馃煝 +0.01 馃煝 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@github-actions github-actions bot temporarily deployed to Netlify March 18, 2024 16:46 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 19, 2024 10:56 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 21, 2024 10:45 Inactive
@nicklem
Copy link
Contributor

nicklem commented Mar 25, 2024

Left a comment with a minor tweak. As far as IA (page structure and placement), LGTM 馃憤

claudiacarpinteiro and others added 2 commits March 26, 2024 09:50
Co-authored-by: Nicola Klemenc <nicola.klemenc@codacy.com>
@github-actions github-actions bot temporarily deployed to Netlify March 26, 2024 09:53 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 26, 2024 09:59 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 26, 2024 10:01 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 26, 2024 10:07 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 26, 2024 15:03 Inactive
@github-actions github-actions bot temporarily deployed to Netlify April 4, 2024 12:20 Inactive
@github-actions github-actions bot temporarily deployed to Netlify April 10, 2024 11:05 Inactive
@github-actions github-actions bot temporarily deployed to Netlify April 17, 2024 09:31 Inactive
@github-actions github-actions bot temporarily deployed to Netlify May 7, 2024 16:11 Inactive
@github-actions github-actions bot temporarily deployed to Netlify May 8, 2024 09:00 Inactive
@github-actions github-actions bot temporarily deployed to Netlify May 8, 2024 11:31 Inactive
@claudiacarpinteiro claudiacarpinteiro marked this pull request as ready for review May 8, 2024 11:38
@claudiacarpinteiro claudiacarpinteiro requested a review from a team as a code owner May 8, 2024 11:38
@claudiacarpinteiro claudiacarpinteiro requested a review from a team May 8, 2024 11:38
Copy link

@andrzej-janczak andrzej-janczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good, very consistent and clear 馃憤

@nicklem
Copy link
Contributor

nicklem commented May 8, 2024

:shipit: LGTM!

@github-actions github-actions bot temporarily deployed to Netlify May 9, 2024 14:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Don't merge this pull request yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants