Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iTerm2 #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YusukeSano
Copy link
Contributor

The terminal.sexy provides iTerm2 color schemes via .Xresources, but some settings, such as Selection and Link, are not supported.

So I created a complete Icebreg for iTerm2 and added port links.

Before After

This also supports separate color settings for light & dark modes, which will be added in the latest beta (3.5) of iTerm2.

Light Dark

@jf
Copy link

jf commented May 21, 2023

hi, just a fan of iceberg here, looking to use it for iTerm2 too. Do you think you could give a brief summary of how your version compares versus https://github.com/epszaw/iceberg-iterm (from #80) ? Thank you!

@YusukeSano
Copy link
Contributor Author

hi, just a fan of iceberg here, looking to use it for iTerm2 too. Do you think you could give a brief summary of how your version compares versus https://github.com/epszaw/iceberg-iterm (from #80) ? Thank you!

Sure! Here's a summary of my color theme file compared to the #80 version of the theme:

  • Compatibility: My theme files are designed to support light & dark mode since version 3.5.
  • Consistency: It aligns with the original .Xresources file for a consistent color experience.
  • Enhanced Colors: I have referenced the VSCode theme file to enrich the color palette.
  • Accurate Representation: The theme file was created using the precise sRGB color values from the iTerm2 Theme Generator.

In summary, my version provides improved compatibility, consistent colors, enhanced palette, and accurate representation.

@jf
Copy link

jf commented May 31, 2023

thank you @YusukeSano ! @cocopon , do you think you could take a look and see if you're ok with this PR? Thank you!

@YusukeSano
Copy link
Contributor Author

iTerm2 version 3.5 has been released! (https://iterm2.com/downloads.html)

Version 3.5 supports color profiles for both light and dark modes.
Additionally, a new find match background color has been added.

Unfortunately, terminal.sexy and #80 do not support the correct terminal colors.
However, Icebreg for iTerm2 fully supports all these updates.

light dark
light dark

Would you kindly review this pull request, @cocopon?

@gkeep
Copy link
Contributor

gkeep commented May 25, 2024

Can confirm, looks and works great. Thanks, @YusukeSano!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants