Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(check): Support commit scope checking #368

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Witcher01
Copy link

Personally, I'm missing this feature. I realise that, ideally, suggestions for scopes are desirable (as written in #42) but having this feature in cocogitto without suggestions is a great improvement already, especially for CI.

The tests fail for me with these changes but I can't figure out why. Some pointers would be appreciated here! Besides the failing tests this is done :)

@Witcher01
Copy link
Author

Looks like the CI is checking for valid keys in the configuration file, but with a different version than in this PR. This fails the pipeline and the tests (which are failing for me but I'm not sure why) are not running.

The configuration file should be checked for valid keys based on the version of the repository that is being updated (i.e. the branch of the fork), otherwise changes in the configuration file cannot be checked (including additions to it which is not a major version bump).

It's been a week since I opened this and haven't received any comments yet.
Is something missing here? I'm asking in case this is not wanted so I can close this. Some quick would be appreciated here.

Thanks!

@oknozor
Copy link
Collaborator

oknozor commented Mar 1, 2024

Hey sorry for the delay, I am currently in vacation and will be reviewing PRs next week. Thanks for your patience.

@Witcher01
Copy link
Author

Thank you for the response, and enjoy your vacation!

@oknozor
Copy link
Collaborator

oknozor commented Mar 7, 2024

Hey @WitcheR0,1 the gpg test keys have been fixed upstream, can you rebase on main so we can move this PR forward ?

@Witcher01
Copy link
Author

Hey @oknozor, I just did!

@Witcher01
Copy link
Author

Not sure why the pipelines are failing anymore. Can they be rerun?

I still haven't figured out why local tests are failing here, so that would help!

@oknozor
Copy link
Collaborator

oknozor commented Apr 15, 2024

You need to remove the changes you made to cog.toml. The CI version of cocogitto fails to initialize because it doesn't know the scopes config attribute.

References: cocogitto#42
Signed-off-by: Thomas Böhler <witcher@wiredspace.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants