db: more readable iterator stats #3611
Conversation
|
This change is |
This change reformats the output of iterator stats which are very hard to read. We omit reverse counts when they are zero and remove redundant information.
RaduBerinde
force-pushed
the
iterator-stats-string
branch
from
dbccb4e
to
be6961f
Compare
There was a problem hiding this comment.
Reviewed 3 of 8 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 3 of 9 files reviewed, 1 unresolved discussion (waiting on @RaduBerinde)
testdata/external_iterator line 248 at r2 (raw file):
aaaaa@3: (aaaaa@3, .) aaaaa@1: (aaaaa@1, .) stats: seeked 5 times (5 internal); stepped 5 times (5 internal); blocks: 547B (0B cached), read time 0s; points: 10 (50B keys, 35B values); separated: 15 (65B, 25B fetched)
do you know how it's possible that the separated value count 15 is higher than the total point key count 10?
There was a problem hiding this comment.
TFTR!
Reviewable status: 3 of 9 files reviewed, 1 unresolved discussion (waiting on @jbowens)
testdata/external_iterator line 248 at r2 (raw file):
Previously, jbowens (Jackson Owens) wrote…
do you know how it's possible that the separated value count
15is higher than the total point key count10?
This comment explains it: https://github.com/cockroachdb/pebble/blob/be6961f4400bfddf6d2000bef19f036f84a8cf42/internal/base/iterator.go#L403-L402
This change reformats the output of iterator stats which are very hard
to read. We omit reverse counts when they are zero and remove
redundant information.