Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: go.mod: switch google cloud to fork of v0.45.1 #66808

Merged

Conversation

adityamaru
Copy link
Contributor

This change switches the release-21.1 branch to point to a
fork of v0.45.1 of the google cloud SDK that includes
googleapis/google-cloud-go#4226.

The above change provides better retry on GOAWAY errors which
have become an increasingly common occurrence in our roachtests.

Release note (general change): Switches the release-21.1 branch
to point to a fork of the google cloud SDK at version 0.45.1
with an upstream bug fix
googleapis/google-cloud-go#4226.

This change switches the release-21.1 branch to point to a
fork of v0.45.1 of the google cloud SDK that includes
googleapis/google-cloud-go#4226.

The above change provides better retry on GOAWAY errors which
have become an increasingly common occurrence in our roachtests.

Release note (general change): Switches the release-21.1 branch
to point to a fork of the google cloud SDK at version 0.45.1
with an upstream bug fix
googleapis/google-cloud-go#4226.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor Author

For posterity the steps I followed were:

*one thing I'm not sure about is why the vendor diff is not showing the changes to the test files. egs: storage/reader_test

@adityamaru adityamaru requested review from pbardea and dt June 24, 2021 01:24
@adityamaru adityamaru marked this pull request as ready for review June 24, 2021 01:24
Copy link
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*one thing I'm not sure about is why the vendor diff is not showing the changes to the test files. egs: storage/reader_test

It looks like the version that we're patching on top of didn't have any of these test files (see
https://github.com/cockroachdb/vendored/tree/62f7cec4ff212ca2a8e0edef07f68fc47b3b8ae0/cloud.google.com/go/storage) so I think the patch wasn't applied (since there's no file to apply to).

The change LGTM; the change looks fairly self-contained and applies the same to this version as it did to the current one.

@adityamaru adityamaru merged commit 33b1b9b into cockroachdb:release-21.1 Jun 24, 2021
@adityamaru adityamaru deleted the google-sdk-goaway-retry branch June 24, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants