Skip to content

Commit

Permalink
changefeedccl: disable drain watcher by default
Browse files Browse the repository at this point in the history
#102717 introduced a mechanism allowing for an orderly shutdown of changefeed
aggregators and an up-to-date frontier information to reduce duplicates during
a node restart in 23.2. However, we've recently identified a bug that could
lead to bad behavior. It's unclear where the bug is yet. This patch disables
this feature by default.

Fixes: #123371
Release note: Disabled a changefeed optimization on reducing duplicates during
aggregator restarts due to its bad performance.
  • Loading branch information
wenyihu6 committed May 2, 2024
1 parent c1ce987 commit 7e77468
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/ccl/changefeedccl/changefeed_processors.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ var aggregatorEmitsShutdownCheckpoint = settings.RegisterBoolSetting(
settings.ApplicationLevel,
"changefeed.shutdown_checkpoint.enabled",
"upon shutdown aggregator attempts to emit an up-to-date checkpoint",
true,
false,
)

type drainWatcher <-chan struct{}
Expand Down
2 changes: 1 addition & 1 deletion pkg/server/drain.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ var (
"server.shutdown.jobs_wait",
"the maximum amount of time a server waits for all currently executing jobs "+
"to notice drain request and to perform orderly shutdown",
10*time.Second,
0,
settings.NonNegativeDurationWithMaximum(10*time.Minute),
settings.WithName("server.shutdown.jobs.timeout"),
settings.WithPublic)
Expand Down

0 comments on commit 7e77468

Please sign in to comment.