test/storagelib: step up our destroy-and-reboot efforts #20449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
reviewed
May 8, 2024
test/common/storagelib.py
Outdated
|
|
||
| # Destroy our current boot device. This prevents the system from | ||
| # shutting down properly, so do it forcefully from outside. | ||
| m.spawn("sync; dd if=/dev/zero of=/dev/vda bs=1M count=100; sync; sync; sync;") |
There was a problem hiding this comment.
You want m.execute() for that to make it sync. Will also fix this failure
|
But more generally, this is just cosmetics -- it's not the shutdown that fails, it's the boot. The systemd askpass agent doesn't properly hand over the passphrase to stratis in the initrd. See #20373 (comment) |
Instead of trying to gracefully shutdown a destroyed system from the inside, do it forcefully from the outside.
allisonkarlitskaya
force-pushed
the
break-reboot
branch
from
3ac228b
to
89e5704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to gracefully shutdown a destroyed system from the inside, do it forcefully from the outside.