New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Btrfs snapshot support #20234
base: main
Are you sure you want to change the base?
Btrfs snapshot support #20234
Conversation
@mvollmer I thought a bit on how we could implement filtering: We could come up with a system where we don't have to hardcode the "filters" in but we could register filters for pages which want that.
This registers a filter which lives in Alternatively, we just hardcode filters:
Page/Card can have I'm not thinking of introducing something like a filter component. But maybe it is interesting to have something usable. |
I think this is a bit too much machinery. Let's just do what we need, and nothing more. |
Alright, after the discussion today in standup:
|
c22d6d0
to
ce13bed
Compare
In btrfs a snapshot is a subvolume with a parent_uuid field filled in with the uuid of the subvolume of which the snapshot is made. Note that btrfs allows one to make a snapshot of a snapshot.
Register crossrefs for snapshots so they show under snapshots in the detail page of a subvolume.
ce13bed
to
528f40a
Compare
@jelly: Yes, I think that's what we want. Good, simple summary. I think we (you and/or @mvollmer and I) agreed on that a while ago somewhere? Perhaps in a video call? Perhaps in an issue? I don't remember where, but if we all agree on that, then that's great. To restart: I definitely do not want them on the overview (and never have) and I think the details pages are the right places for the snapshots. |
Show snapshots of a subvolume in the detail view.