New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: Action redesign #19882
base: main
Are you sure you want to change the base?
storage: Action redesign #19882
Conversation
efddee6
to
5c026f1
Compare
fea8037
to
e73add8
Compare
And make "Mount" and "Create new logical volume" primary actions.
Offer it on the "Partition" card instead of the "Filesystem" card, for example. This makes more sense. One formats a partition, but mounts the filesystem.
That's where they belong. Filesystems are still automatically locked and unlocked when mounting and unmounting them.
They have no actions anymore.
e73add8
to
5d6f76b
Compare
87fb4c6
to
bcf8bb1
Compare
This allows us to make the format dialogs non-dangerous and primary, and give them more descriptive names. The "Create partition" version of the "Format" dialog now defaults to "empty", and "empty" can not be encrypted. This makes it a very simple dialog.
fa9ef75
to
21ded11
Compare
@garrett, what do you think of this? There is a demo: https://youtu.be/BkDCAOvOPVc . One point I didn't make in the demo: The awkward "Unformatted data" and "Locked data" cards are gone. |
Some things from my side: It looks interesting!
|
Thanks, yes! And I exactly share your concerns!
Hmm. We could add "swap" as a type to the "Create partition dialog". It can do more than filesystems anyway, like "biosboot" etc. I really wanted to have "Format as filesystem" as the action title, and then we can't have anything else but filesystems in it. And if we want to still allow people to make swap on arbitrary block devices, we need a "Format as swap" action.
Yes, I was going back and forth on the menu order many times, exactly because I wanted the two "Format as ..." next to each other. But "Add encryption" is argueably more important than formatting swap, so... I really don't know.
Absolutely. I am not happy about the wording.
"Format with encryption only"? This could give the idea that other actions can also use encryption.
"Format as encrypted filesystem"? "Erase encrypted device"? This is a good PR for a user study... |
It's not a secure erase by any means.
Use radio buttons, and only offer MBR when it will work.
So I start to have doubts about making "Erase" and "Format" mutually exclusive. It just forces people to do in two steps what the tool can actually do in one. I still think it's good to have a dedicated "Erase" action and dialog, but we shouldn't hide "Format as ..." until people have done the Erase. |
Action redesign for Storage
Demo: https://youtu.be/BkDCAOvOPVc
Goals:
Simplify the "Format" dialog. It does too much.
Especially, don't require people to figure out that they need to
use it with type "No filesystem" to wipe a block device before they
can use it as a LVM2 physical volume, etc.
Design: