New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds split functions for sequence types including lists, vectors, seqs and strings #1083
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future it might be nice for this to work on any sequence type with any Eq element type
A few updates on the most recent commit:
|
I'm not 100% convinced this is a class we should include. My main reason is that it seems a little contrived: we wanted something generic so we forced it to be. I think the true generic aspect of something that splittable isn't that it's splittable, but rather that elements have a natural ordering (i.e., they can be indexed) and each element can be accessed in finite time. My recommendation for the direction of this PR is to create a function |
Now this merely defines a function split for string, seq, list, and vector. |
5f71597
to
8242ff2
Compare
No urgency, but ready for review whenever the next PR/Issue cleanup happens. 5/10:
|
This adds splitting by single-character delimiters