mentors.html: Change mentor page year dynamically #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @aedorado, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: b59c60c0-2914-11e9-9de4-fb4b948767f7 |
|
@li-boxuan Please review the PR. |
li-boxuan
requested changes
Feb 5, 2019
resources/js/app.js
Outdated
| @@ -386,6 +386,16 @@ | |||
| self.mentorsList = {} | |||
| self.adminsList = {} | |||
|
|
|||
| $scope.getGsocYear = function() { | |||
| var gsocSwitchMonth = 6; | |||
| var currentdate = new Date(); | |||
There was a problem hiding this comment.
Suggested change
| var currentdate = new Date(); | |
| var currentDate = new Date(); |
resources/js/app.js
Outdated
| @@ -386,6 +386,16 @@ | |||
| self.mentorsList = {} | |||
| self.adminsList = {} | |||
|
|
|||
| $scope.getGsocYear = function() { | |||
| var gsocSwitchMonth = 6; | |||
There was a problem hiding this comment.
I prefer reading the number from
Line 9 in ca8a58f
There was a problem hiding this comment.
Hi @li-boxuan . Not entirely sure how we can go about injecting this variable into the angularjs script. Do you have anything in mind?
There was a problem hiding this comment.
I could add frontmatter to the file app.js and use the variable as var gsocSwitchMonth = {{ site.gsoc_switch_month }}. Does this look like a good enough solution to you?
There was a problem hiding this comment.
Hi @li-boxuan Made the desired changes.
Have the year on the GSoC mentor page change dynamically based on the current month. If it's past September, the page will show the next year, otherwise it will show the current year. Closes coala#706
Travis tests have failedHey @aedorado, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 656d0830-2b16-11e9-bdf3-9bb996cd785e |
areebbeigh
reviewed
Feb 8, 2019
There was a problem hiding this comment.
Lines 396 to 398 in 9bf75d3
Maybe get rid of the else block and replace it with return currentDate.getFullYear()
jayvdb
reviewed
Feb 8, 2019
| @@ -1,3 +1,5 @@ | |||
| --- | |||
| --- | |||
There was a problem hiding this comment.
@jayvdb This is the frontmatter needed by jekyll to interpolate a file. Without this we cannot read the value gsocSwitchMonth from the _config.yml file as suggested by @li-boxuan.
There was a problem hiding this comment.
To avoid this @aedorado you can pass the value to function getGsocYear() from html page itself.
Doing so, will omit those two new lines containing hyphen
There was a problem hiding this comment.
Yes please. embedding jekyll liquid variables inside JS is just too confusing ;-)
|
Also, rebase needed ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the year on the GSoC mentor page change dynamically
based on the current month. If it's past September, the page
will show the next year, otherwise it will show the current year.
Closes #706