Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox.ini #574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tox.ini #574

wants to merge 1 commit into from

Conversation

ManthanKeim
Copy link
Member

tox.ini explains how to set up coala in tox properly.

Closes #344

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

tox.ini explains how to set up coala in tox properly.
@palash25
Copy link
Member

@ManthanKeim just one suggestion never make a PR from your master, always checkout a new branch from the master for a particular issue and keep your master clean.

We can overlook this mistake for now but you should keep this best practice in mind so that you are able to work on multiple PRs simultaneously in the future 😉

@ManthanKeim
Copy link
Member Author

@palash25 thanks for the suggestion. I will surely consider that for future PRs.

@jayvdb
Copy link
Member

jayvdb commented Oct 15, 2018

@ManthanKeim , this task is to create documentation about tox.ini, not add a tox.ini to this repo.

Copy link
Member

@ananyaarun ananyaarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ManthanKeim , Kindly read this https://api.coala.io/en/latest/Developers/Newcomers_Guide.html#step-3-creating-a-fork-and-testing-your-changes , These are some reasons why I would suggest you to not make PR's from master branch itself.
Also, Change your commit from "add" to "create"
else this Looks good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add tox setup page
5 participants