Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker_image.rst: remove pip install instruction #493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vipuldcoder
Copy link

@vipuldcoder vipuldcoder commented Nov 11, 2017

pip install is unnecessary in Docker Image docs.

Fixes #486

Copy link
Contributor

@newbazz newbazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the commit guide lines and change the commit message accordingly.

Copy link
Member

@stellargo stellargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention file changed in title and add a commit body :)
http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

@vipuldcoder vipuldcoder changed the title pip install remove from Docker_image.rst #486 Docker_image.rst: remove pip install instruction Nov 11, 2017
@yukiisbored
Copy link
Member

Hello,

Please read the commit guidelines (coala.io/commit) and change your commit message.

For information on how to change your commit message, refer to coala.io/rebase.

@neelanshsahai
Copy link

unack a448fdf
@vipuldcoder it would be better if your shortlog and the commit body are visible and same in both, the conversation as well as the commits section 👍

@yukiisbored
Copy link
Member

yukiisbored commented Nov 16, 2017

@neelanshsahai You don't need to unack just to request changes, use GitHub's feature or just make it a comment.
Of course, unack is used when you disagree that this is acceptable and has been ack'd by someone else.

Copy link
Member

@prashant0598 prashant0598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yukiisbored
Copy link
Member

yukiisbored commented Nov 19, 2017

@vipuldcoder ugh, the dreaded merge commit.

Anyway to fix this, please do the following:

  1. Create a new branch based of this branch you're using for this PR. git checkout -b <whatever you wanna call>
  2. Make sure you've fetched/pulled the latest master branch. git pull <whatever your remote to the coala repo is> master
  3. Checkout to master. git checkout master
  4. Delete the branch you're using for this PR. DON'T WORRY, GitHub only cares about the branch name, we'll fix it later. git branch -D <the branch name>
  5. Create a new branch based of the latest master with the same name as you're using for this PR. git checkout -b <whatever the name is>
  6. Cherrypick your commit to your new branch. git cherry-pick <the commit hash of whatever you did>
  7. Do a force push to your fork. git push -f -u <whatever your fork remote is> <whatever your branch name is>

@neelanshsahai
Copy link

@vipuldcoder please rectify your PR asap
Squashing the commits and updating your Shortlog and Commit Body would be great. 👍

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2018

@gitmate-bot rebase

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated rebase with GitMate.io was successful! 🎉

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2018

Please fix your commit message to abide by http://coala.io/commit .
Otherwise we will close this PR as abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

9 participants