FileGlobs.py: Recursively extract .npmignore globs #168

prachi1210 · 2017-08-08T14:08:36Z

Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes #109

gitmate-bot · 2017-08-08T14:09:01Z

tests/generation/FileGlobs.py

+                    self.log_printer, self.printer, os.getcwd())[0]),
+                sorted(files))
+
+        os.remove(os.path.join("other_folder",".npmignore"))


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:02Z

tests/generation/FileGlobs.py

+                              os.path.join(os.getcwd(), "other_folder"),
+                              os.path.join(os.getcwd(), "sample_data", "data")]
+
+        globs = list(get_npmignore_glob(os.getcwd(),npmignore_dir_list))


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:03Z

tests/generation/FileGlobs.py

+            os.path.join("src", "abc.pyc"),
+            os.path.join("other_folder","test.html"),
+            os.path.join("sample_data","data","test.css"),
+            "run.pyc"]


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:04Z

tests/generation/FileGlobs.py

+            "upload.c",
+            os.path.join("src", "abc.pyc"),
+            os.path.join("other_folder","test.html"),
+            os.path.join("sample_data","data","test.css"),


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:05Z

tests/generation/FileGlobs.py

+            "upload.c",
+            os.path.join("src", "abc.pyc"),
+            os.path.join("other_folder","test.html"),
+            os.path.join("sample_data","data","test.css"),


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:06Z

tests/generation/FileGlobs.py

+            "upload.c",
+            os.path.join("src", "abc.pyc"),
+            os.path.join("other_folder","test.html"),
+            os.path.join("sample_data","data","test.css"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:07Z

tests/generation/FileGlobs.py

+            "glob2.py",
+            "upload.c",
+            os.path.join("src", "abc.pyc"),
+            os.path.join("other_folder","test.html"),


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:08Z

tests/generation/FileGlobs.py

+            "glob2.py",
+            "upload.c",
+            os.path.join("src", "abc.pyc"),
+            os.path.join("other_folder","test.html"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:10Z

tests/generation/FileGlobs.py

+            os.path.join("src", "ignore.c"),
+            "glob2.py",
+            "upload.c",
+            os.path.join("src", "abc.pyc"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:11Z

tests/generation/FileGlobs.py

+            "ignore.c",
+            os.path.join("src", "ignore.c"),
+            "glob2.py",
+            "upload.c",


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:11Z

tests/generation/FileGlobs.py

+            os.path.join("src", "build", "main.c"),
+            "ignore.c",
+            os.path.join("src", "ignore.c"),
+            "glob2.py",


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:12Z

tests/generation/FileGlobs.py

+            os.path.join("tests", "run.c"),
+            os.path.join("src", "build", "main.c"),
+            "ignore.c",
+            os.path.join("src", "ignore.c"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:13Z

tests/generation/FileGlobs.py

+        ignored_files = [os.path.join("build", "main.c"),
+            os.path.join("tests", "run.c"),
+            os.path.join("src", "build", "main.c"),
+            "ignore.c",


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:14Z

tests/generation/FileGlobs.py

+            ".coafile"]
+        ignored_files = [os.path.join("build", "main.c"),
+            os.path.join("tests", "run.c"),
+            os.path.join("src", "build", "main.c"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:15Z

tests/generation/FileGlobs.py

+            os.path.join("sample_data", "example.py"),
+            ".coafile"]
+        ignored_files = [os.path.join("build", "main.c"),
+            os.path.join("tests", "run.c"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:16Z

tests/generation/FileGlobs.py

+            os.path.join("other_folder", "new_file.c"),
+            os.path.join("sample_data", "data", "new_script.js"),
+            os.path.join("sample_data", "example.py"),
+            ".coafile"]


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:16Z

tests/generation/FileGlobs.py

+            os.path.join("src", "upload.c"),
+            os.path.join("other_folder", "new_file.c"),
+            os.path.join("sample_data", "data", "new_script.js"),
+            os.path.join("sample_data", "example.py"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:17Z

tests/generation/FileGlobs.py

+            os.path.join("src", "abc.py"),
+            os.path.join("src", "upload.c"),
+            os.path.join("other_folder", "new_file.c"),
+            os.path.join("sample_data", "data", "new_script.js"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:18Z

tests/generation/FileGlobs.py

+            os.path.join("src", "tests", "main.c"),
+            os.path.join("src", "abc.py"),
+            os.path.join("src", "upload.c"),
+            os.path.join("other_folder", "new_file.c"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:19Z

tests/generation/FileGlobs.py

+            os.path.join("src", "lib", "ssl.c"),
+            os.path.join("src", "tests", "main.c"),
+            os.path.join("src", "abc.py"),
+            os.path.join("src", "upload.c"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:20Z

tests/generation/FileGlobs.py

+            os.path.join("src", "main.h"),
+            os.path.join("src", "lib", "ssl.c"),
+            os.path.join("src", "tests", "main.c"),
+            os.path.join("src", "abc.py"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:21Z

tests/generation/FileGlobs.py

+        files = [os.path.join("src", "main.c"),
+            os.path.join("src", "main.h"),
+            os.path.join("src", "lib", "ssl.c"),
+            os.path.join("src", "tests", "main.c"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:23Z

tests/generation/FileGlobs.py

+        os.chdir("file_globs_npmignore_testfiles")
+        files = [os.path.join("src", "main.c"),
+            os.path.join("src", "main.h"),
+            os.path.join("src", "lib", "ssl.c"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:23Z

tests/generation/FileGlobs.py

+        os.chdir(os.path.dirname(os.path.realpath(__file__)))
+        os.chdir("file_globs_npmignore_testfiles")
+        files = [os.path.join("src", "main.c"),
+            os.path.join("src", "main.h"),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-08T14:09:24Z

tests/generation/FileGlobs.py

+                    self.log_printer, self.printer, os.getcwd())[0]),
+                sorted(files))
+
+        os.remove(os.path.join("other_folder",".npmignore"))


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/generation/FileGlobs.py +++ b/tests/generation/FileGlobs.py @@ -191,7 +191,7 @@ self.log_printer, self.printer, os.getcwd())[0]), sorted(files)) - os.remove(os.path.join("other_folder",".npmignore")) + os.remove(os.path.join("other_folder", ".npmignore")) os.remove(os.path.join("sample_data", "data", ".npmignore")) os.remove(".npmignore") os.chdir(orig_cwd)

gitmate-bot · 2017-08-08T14:09:25Z

tests/generation/FileGlobs.py

+                              os.path.join(os.getcwd(), "other_folder"),
+                              os.path.join(os.getcwd(), "sample_data", "data")]
+
+        globs = list(get_npmignore_glob(os.getcwd(),npmignore_dir_list))


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/generation/FileGlobs.py +++ b/tests/generation/FileGlobs.py @@ -174,7 +174,7 @@ os.path.join(os.getcwd(), "other_folder"), os.path.join(os.getcwd(), "sample_data", "data")] - globs = list(get_npmignore_glob(os.getcwd(),npmignore_dir_list)) + globs = list(get_npmignore_glob(os.getcwd(), npmignore_dir_list)) returned_files = collect_files( [os.path.join(os.getcwd(), "**")],

gitmate-bot · 2017-08-08T14:09:26Z

tests/generation/FileGlobs.py

+        os.chdir(os.path.dirname(os.path.realpath(__file__)))
+        os.chdir("file_globs_npmignore_testfiles")
+        files = [os.path.join("src", "main.c"),
+            os.path.join("src", "main.h"),


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/generation/FileGlobs.py +++ b/tests/generation/FileGlobs.py @@ -142,26 +142,26 @@ os.chdir(os.path.dirname(os.path.realpath(__file__))) os.chdir("file_globs_npmignore_testfiles") files = [os.path.join("src", "main.c"), - os.path.join("src", "main.h"), - os.path.join("src", "lib", "ssl.c"), - os.path.join("src", "tests", "main.c"), - os.path.join("src", "abc.py"), - os.path.join("src", "upload.c"), - os.path.join("other_folder", "new_file.c"), - os.path.join("sample_data", "data", "new_script.js"), - os.path.join("sample_data", "example.py"), - ".coafile"] + os.path.join("src", "main.h"), + os.path.join("src", "lib", "ssl.c"), + os.path.join("src", "tests", "main.c"), + os.path.join("src", "abc.py"), + os.path.join("src", "upload.c"), + os.path.join("other_folder", "new_file.c"), + os.path.join("sample_data", "data", "new_script.js"), + os.path.join("sample_data", "example.py"), + ".coafile"] ignored_files = [os.path.join("build", "main.c"), - os.path.join("tests", "run.c"), - os.path.join("src", "build", "main.c"), - "ignore.c", - os.path.join("src", "ignore.c"), - "glob2.py", - "upload.c", - os.path.join("src", "abc.pyc"), - os.path.join("other_folder","test.html"), - os.path.join("sample_data","data","test.css"), - "run.pyc"] + os.path.join("tests", "run.c"), + os.path.join("src", "build", "main.c"), + "ignore.c", + os.path.join("src", "ignore.c"), + "glob2.py", + "upload.c", + os.path.join("src", "abc.pyc"), + os.path.join("other_folder", "test.html"), + os.path.join("sample_data", "data", "test.css"), + "run.pyc"] for file in files + ignored_files: os.makedirs(os.path.dirname(os.path.abspath(file)), exist_ok=True)

gitmate-bot · 2017-08-16T15:24:55Z

tests/generation/FileGlobs.py

+            open(file, "w").close()
+        files += [".gitignore"]
+        files += [os.path.join("other_folder", ".npmignore")]
+        files += [os.path.join("sample_data", "data", ".npmignore")]  


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/generation/FileGlobs.py +++ b/tests/generation/FileGlobs.py @@ -171,7 +171,7 @@ open(file, "w").close() files += [".gitignore"] files += [os.path.join("other_folder", ".npmignore")] - files += [os.path.join("sample_data", "data", ".npmignore")] + files += [os.path.join("sample_data", "data", ".npmignore")] gitignore_dir_list = [os.path.join(os.getcwd())] npmignore_dir_list = [os.path.join(os.getcwd(), "other_folder"),

gitmate-bot · 2017-08-16T15:24:56Z

tests/generation/FileGlobs.py

+            open(file, "w").close()
+        files += [".gitignore"]
+        files += [os.path.join("other_folder", ".npmignore")]
+        files += [os.path.join("sample_data", "data", ".npmignore")]  


Line contains following spacing inconsistencies:

Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/FileGlobs.py +++ b/tests/generation/FileGlobs.py @@ -171,7 +171,7 @@ open(file, "w").close() files += [".gitignore"] files += [os.path.join("other_folder", ".npmignore")] - files += [os.path.join("sample_data", "data", ".npmignore")] + files += [os.path.join("sample_data", "data", ".npmignore")] gitignore_dir_list = [os.path.join(os.getcwd())] npmignore_dir_list = [os.path.join(os.getcwd(), "other_folder"),

gitmate-bot · 2017-08-18T16:26:17Z

tests/generation/FileGlobs.py

+        files += [os.path.join("other_folder", ".npmignore")]
+        files += [os.path.join("sample_data", "data", ".npmignore")]
+
+        gitignore_dir_list = [os.path.join(os.getcwd())]


This file contains unused source code.

PyUnusedCodeBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/FileGlobs.py +++ b/tests/generation/FileGlobs.py @@ -173,7 +173,7 @@ files += [os.path.join("other_folder", ".npmignore")] files += [os.path.join("sample_data", "data", ".npmignore")] - gitignore_dir_list = [os.path.join(os.getcwd())] + [os.path.join(os.getcwd())] npmignore_dir_list = [os.path.join(os.getcwd(), "other_folder"), os.path.join(os.getcwd(), "sample_data", "data")]

gitmate-bot · 2017-08-18T16:48:35Z

tests/generation/FileGlobs.py

+        for file in files + ignored_files:
+            os.makedirs(os.path.dirname(os.path.abspath(file)), exist_ok=True)
+            open(file, "w").close()
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/FileGlobs.py +++ b/tests/generation/FileGlobs.py @@ -168,7 +168,7 @@ for file in files + ignored_files: os.makedirs(os.path.dirname(os.path.abspath(file)), exist_ok=True) open(file, "w").close() - + files += [os.path.join("other_folder", ".npmignore")] files += [os.path.join("sample_data", "data", ".npmignore")]

gitmate-bot · 2017-08-18T16:48:36Z

tests/generation/FileGlobs.py

+        for file in files + ignored_files:
+            os.makedirs(os.path.dirname(os.path.abspath(file)), exist_ok=True)
+            open(file, "w").close()
+


W293 blank line contains whitespace'

PycodestyleBear (W293), severity NORMAL, section autopep8.

gitmate-bot · 2017-08-18T16:48:36Z

tests/generation/FileGlobs.py

+        for file in files + ignored_files:
+            os.makedirs(os.path.dirname(os.path.abspath(file)), exist_ok=True)
+            open(file, "w").close()
+


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/generation/FileGlobs.py +++ b/tests/generation/FileGlobs.py @@ -168,7 +168,7 @@ for file in files + ignored_files: os.makedirs(os.path.dirname(os.path.abspath(file)), exist_ok=True) open(file, "w").close() - + files += [os.path.join("other_folder", ".npmignore")] files += [os.path.join("sample_data", "data", ".npmignore")]

gitmate-bot · 2017-08-18T16:59:58Z

coala_quickstart/generation/FileGlobs.py

+
+    globs = get_npmignore_glob(project_dir, npmignore_dir_list)
+    for glob in globs:
+            ignore_globs += glob


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/coala_quickstart/generation/FileGlobs.py +++ b/coala_quickstart/generation/FileGlobs.py @@ -45,7 +45,7 @@ globs = get_npmignore_glob(project_dir, npmignore_dir_list) for glob in globs: - ignore_globs += glob + ignore_globs += glob if non_interactive and not ignore_globs: ignore_globs = []

gitmate-bot · 2017-08-18T17:01:00Z

coala_quickstart/generation/FileGlobs.py

+
+    globs = get_npmignore_glob(project_dir, npmignore_dir_list)
+    for glob in globs:
+            ignore_globs += glob


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/coala_quickstart/generation/FileGlobs.py +++ b/coala_quickstart/generation/FileGlobs.py @@ -45,7 +45,7 @@ globs = get_npmignore_glob(project_dir, npmignore_dir_list) for glob in globs: - ignore_globs += glob + ignore_globs += glob if non_interactive and not ignore_globs: ignore_globs = []

Looks for .npmignore in dirs and subdirs recursively and extract file globs Closes coala#109

gitmate-bot added process/pending review size/XXL labels Aug 8, 2017

gitmate-bot reviewed Aug 8, 2017

View reviewed changes

prachi1210 force-pushed the prachi1210/#109 branch from 02b878f to 7252f06 Compare August 8, 2017 14:21

gitmate-bot reviewed Aug 16, 2017

View reviewed changes

co-robo added process/wip and removed process/pending review labels Aug 16, 2017

prachi1210 force-pushed the prachi1210/#109 branch from fe9fd56 to b41c6c4 Compare August 18, 2017 16:16

gitmate-bot added process/pending review and removed process/wip labels Aug 18, 2017

co-robo added process/wip and removed process/pending review labels Aug 18, 2017

prachi1210 force-pushed the prachi1210/#109 branch from b41c6c4 to 92532e8 Compare August 18, 2017 16:25

gitmate-bot added process/pending review and removed process/wip labels Aug 18, 2017

gitmate-bot reviewed Aug 18, 2017

View reviewed changes

prachi1210 force-pushed the prachi1210/#109 branch 2 times, most recently from 569e7ab to e9ecc9a Compare August 18, 2017 16:48

gitmate-bot reviewed Aug 18, 2017

View reviewed changes

prachi1210 force-pushed the prachi1210/#109 branch 2 times, most recently from 9236101 to ac83598 Compare August 18, 2017 16:59

gitmate-bot reviewed Aug 18, 2017

View reviewed changes

prachi1210 force-pushed the prachi1210/#109 branch from ac83598 to e71d438 Compare August 18, 2017 17:00

gitmate-bot reviewed Aug 18, 2017

View reviewed changes

prachi1210 force-pushed the prachi1210/#109 branch 2 times, most recently from 9cd63ea to f1b6ed5 Compare August 18, 2017 17:05

FileGlobs.py: Recursively extract .npmignore globs

0ee49ab

Looks for .npmignore in dirs and subdirs recursively and extract file globs Closes coala#109

prachi1210 force-pushed the prachi1210/#109 branch from f1b6ed5 to 0ee49ab Compare August 18, 2017 17:11

co-robo added process/wip and removed process/pending review labels Aug 18, 2017

gitmate-bot added the status/STALE label Aug 31, 2017

FileGlobs.py: Recursively extract .npmignore globs #168

Are you sure you want to change the base?

FileGlobs.py: Recursively extract .npmignore globs #168

Conversation

prachi1210 commented Aug 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment