Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukrainian language #837

Merged
merged 5 commits into from Oct 7, 2023
Merged

Add Ukrainian language #837

merged 5 commits into from Oct 7, 2023

Conversation

khvalera
Copy link
Contributor

@khvalera khvalera commented Aug 1, 2023

Add Ukrainian language

@khvalera khvalera force-pushed the master branch 2 times, most recently from 402a152 to 0e869b9 Compare August 4, 2023 22:22
scripts/build.sh Outdated

yarn install
yarn build-prod
cd dist/cncjs/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a neat trick you can use here:

pushd dist/cncjs
...
popd

This will move between directories then restore your original position without having to cd .. twice (or more)!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it will be more beautiful, corrected 6e514d2

Copy link

@rsteckler rsteckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some blank translations. What's the behavior in that situation? Do they show up as blank labels or fallback to English?

@khvalera
Copy link
Contributor Author

If there are untranslated strings, you need to display in English. I need to look at a concrete example. Or I was at a loss with the correct translation or left it to translate later.

@khvalera
Copy link
Contributor Author

The translation was done by 98%, all the main things are translated correctly. The translation was checked and adjusted to the program interface.

@cheton cheton merged commit b1735c1 into cncjs:master Oct 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants