New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ukrainian language #837
Conversation
402a152
to
0e869b9
Compare
scripts/build.sh
Outdated
|
||
yarn install | ||
yarn build-prod | ||
cd dist/cncjs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a neat trick you can use here:
pushd dist/cncjs
...
popd
This will move between directories then restore your original position without having to cd ..
twice (or more)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it will be more beautiful, corrected 6e514d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some blank translations. What's the behavior in that situation? Do they show up as blank labels or fallback to English?
If there are untranslated strings, you need to display in English. I need to look at a concrete example. Or I was at a loss with the correct translation or left it to translate later. |
The translation was done by 98%, all the main things are translated correctly. The translation was checked and adjusted to the program interface. |
Add Ukrainian language