Conformance results for v1.9/kubeadm #123
Conversation
| kubectl apply -f https://git.io/weave-kube-1.6 | ||
| kubectl taint nodes --all node-role.kubernetes.io/master- | ||
|
|
||
| curl -L https://raw.githubusercontent.com/cncf/k8s-conformance/master/sonobuoy-conformance.yaml | kubectl apply -f - |
There was a problem hiding this comment.
Note that this is actually:
https://raw.githubusercontent.com/stealthybox/k8s-conformance/c17241e9307b877f1a10922a67ff0bba98d62b80/sonobuoy-conformance.yaml
until #122 is merged into master.
There was a problem hiding this comment.
This is now merged.
|
Fixes kubernetes/kubeadm#617. |
| kubeadm init | ||
| export KUBECONFIG=/etc/kubernetes/admin.conf | ||
| echo "export KUBECONFIG=/etc/kubernetes/admin.conf" >> /etc/bash.bashrc | ||
| kubectl apply -f https://git.io/weave-kube-1.6 |
There was a problem hiding this comment.
I'd prefer this:
kubectl apply -f "https://cloud.weave.works/k8s/net?k8s-version=$(kubectl version | base64 | tr -d '\n')"
ref: https://www.weave.works/docs/net/latest/kubernetes/kube-addon/#install
v1.9/kubeadm/README.md
Outdated
| apt-get update && apt-get install -y apt-transport-https | ||
| curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key add - | ||
| echo "deb http://apt.kubernetes.io/ kubernetes-xenial main" > /etc/apt/sources.list.d/kubernetes.list | ||
| apt-get update && apt-get install -y kubelet kubeadm kubectl docker.io |
There was a problem hiding this comment.
On my env, it installed docker version 1.6.2 with this command. It's so low a version...
There was a problem hiding this comment.
@xiangpengzhao did you use the Vagrantfile?
I'm seeing 1.13.1 on my vagrant using docker version and apt show docker.io.
There was a problem hiding this comment.
No, I didn't use the Vagrantfile. I followed the steps that of 1.8 tests. I thought it might have the same version issue here. Didn't notice the Vagrantfile :)
There was a problem hiding this comment.
As long as you have Ubuntu 16.04+ it should be ok I think
There was a problem hiding this comment.
@luxas I tried to run that apt command on 14.04 and got a lower docker version. Yeah as you said, 16.04 is ok :)
There was a problem hiding this comment.
This is a good example of why I codified the steps.
There are so many variables and opinions in OS setup.
|
/cc @luxas |
|
@timothysc Could you please resolve #122 so that we can have people certify to 1.9 using the 'official' Sonobuoy harness? I'd like to make the process as replicatable as possible for everyone else. @luxas Any concerns? |
There was a problem hiding this comment.
Thanks @stealthybox for this PR!!
The only comment I have here is on simplifying the instructions how to reproduce. I'd like to just assume the user can provision an Ubuntu 16.04+ box and provide them with a script to run, like this: master...luxas:patch-1
I don't know what others think would be reasonable, cc @timothysc
v1.9/kubeadm/README.md
Outdated
| # Reproduce Conformance Results: | ||
|
|
||
| ## pre-reqs | ||
| - vagrant + virtualbox |
There was a problem hiding this comment.
I'm not sure if we want to mandate how the VM should be provisioned... Would "just start an Ubuntu 16.04+ machine"
(as an example) work for you instead?
There was a problem hiding this comment.
This isn't a mandate, just a provable way of reproducing these results.
Vagrant is a good MVP for this since it provides code for doing so.
I ran into two issues when trying to reproduce that this code addresses:
- needed to disable swap
- not enough compute to schedule conformance pod
Readers of this doc should be able to copy the shell script portion of the Vagrantfile to fit their needs.
v1.9/kubeadm/README.md
Outdated
| apt-get update && apt-get install -y apt-transport-https | ||
| curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key add - | ||
| echo "deb http://apt.kubernetes.io/ kubernetes-xenial main" > /etc/apt/sources.list.d/kubernetes.list | ||
| apt-get update && apt-get install -y kubelet kubeadm kubectl docker.io |
There was a problem hiding this comment.
As long as you have Ubuntu 16.04+ it should be ok I think
v1.9/kubeadm/README.md
Outdated
| kubectl exec -it -n sonobuoy sonobuoy-e2e-job-${AUTOGEN_JOB_ID} -c e2e kubectl version > /vagrant/v1.9/version.txt | ||
| ``` | ||
|
|
||
| ## untar results |
There was a problem hiding this comment.
Meta nit, I'd prefer "Untar the conformance results" or similar here, with the first char capitalized
There was a problem hiding this comment.
I'll make these headers nicer.
v1.9/kubeadm/README.md
Outdated
| ``` | ||
|
|
||
| ## generate version.txt | ||
| **Important:** do this before conformance tests finish or the pod will die. |
There was a problem hiding this comment.
If we really go with the vagrant thing here, can't this be automated?
There was a problem hiding this comment.
version.txt should document the client that actually ran the tests, so the command should use kubectl inside the conformance pod.
We could automate this in the provision script, but it would require sleeping or polling until the pod is alive.
If the sonobuoy deployment fails to start or load plugins, the user will need to be warned and informed on how to reproduce this.
It seems more reasonable to expect that kube-conformance would produce version.txt.
@timothysc WDYT? (related #27)
For now, this is how you reproduce what I did.
|
You are now certified Kubernetes |
| ## Pre-Reqs | ||
| - vagrant + virtualbox | ||
|
|
||
| ## Provision |
There was a problem hiding this comment.
So in the future if we want to reference the https://github.com/heptio/aws-quickstart as a much easier repro-provisioning just let me know. We are refreshing for 1.9 at the end of the month.
There was a problem hiding this comment.
I'd honestly prefer this to be as vendor-neutral as we can... => as I said I'd welcome Heptio as a "corporate backer" or "point of contact for these results as well"
vendor: Weaveworks
name: kubeadm
version: v1.9.0
website_url: https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm/
documentation_url: https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm/
product_logo_url: https://raw.githubusercontent.com/kubernetes/kubernetes/master/logo/logo.svg