-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mboukhalfa, seifrajhi, adowair as codeowners for AR #3141
base: dev-ar
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This commit will add mboukhalfa, seifrajhi, and adowair as codeowners for the Arabic CNCF glossary. Signed-off-by: Ali Dowair <adowair@umich.edu>
@arezk84 Did you notice the error message on the Changed Files tab ? |
@mboukhalfa |
From the GitHub Docs, it looks we we need to have write access to the repo first:
...and this is defined in Lines 112 to 123 in 5c1f681
|
This commit will also give the proposed codeowners push permissons to the repository, as this is a requirement for code ownershp to work properly. Signed-off-by: Ali Dowair <adowair@umich.edu>
Describe your changes
This commit will add mboukhalfa, seifrajhi, and adowair as codeowners for the Arabic CNCF glossary.
Related issue number or link (ex:
resolves #issue-number
)https://cloud-native.slack.com/archives/C02UFT8V256/p1714310155244299
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.