Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mboukhalfa, seifrajhi, adowair as codeowners for AR #3141

Open
wants to merge 2 commits into
base: dev-ar
Choose a base branch
from

Conversation

adowair
Copy link

@adowair adowair commented May 10, 2024

Describe your changes

This commit will add mboukhalfa, seifrajhi, and adowair as codeowners for the Arabic CNCF glossary.

Related issue number or link (ex: resolves #issue-number)

https://cloud-native.slack.com/archives/C02UFT8V256/p1714310155244299

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Copy link

netlify bot commented May 10, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 560a116
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6644e2951b736a000846de14
😎 Deploy Preview https://deploy-preview-3141--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adowair
Copy link
Author

adowair commented May 10, 2024

This commit will add mboukhalfa, seifrajhi, and adowair as
codeowners for the Arabic CNCF glossary.

Signed-off-by: Ali Dowair <adowair@umich.edu>
@adowair adowair changed the title Add mboukhalfa, adowair as codeowners for Arabic Add mboukhalfa, seifrajhi, adowair as codeowners for AR May 10, 2024
@mboukhalfa
Copy link

@arezk84 Did you notice the error message on the Changed Files tab ?

@arezk84
Copy link
Collaborator

arezk84 commented May 11, 2024

@mboukhalfa
No, I assumed if this PR is accepted, these suggested owners will get the written permission.

@TarekMSayed TarekMSayed self-requested a review May 13, 2024 11:36
@jihoon-seo jihoon-seo added lang/ar for Arabic maintainers Use this label if PR requires maintainers to take action labels May 14, 2024
@adowair
Copy link
Author

adowair commented May 15, 2024

From the GitHub Docs, it looks we we need to have write access to the repo first:

The people you choose as code owners must have write permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.

...and this is defined in .github/settings.yml:

# l10n ar approvers
- username: TarekMSayed
permission: push
- username: same7ammar
permission: push
- username: AShabana
permission: push
- username: arezk84
permission: push

This commit will also give the proposed codeowners
push permissons to the repository, as this is a
requirement for code ownershp to work properly.

Signed-off-by: Ali Dowair <adowair@umich.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ar for Arabic maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants