-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES] eBPF translated to Spanish #3067
base: dev-es
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SullyMA, thanks for submitting this PR.
All the commits should be "signed-off" to have the tests in green. It seems there are 3 commits on this PR but just the last one has been signed. So, you can do a git ammend|reset the previous commits to fix this.
Please reach out to us if you need help with this :)
a1f6718
to
a9c0706
Compare
Signed-off-by: Sully M <sullymartinezj@gmail.com> Signed-off-by: Sully Martinez <sullymartinezj@gmail.com>
a9c0706
to
eefc910
Compare
Co-authored-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consider we should use módulo/módulos instead extensión/extensiones for modules, since the latter term could blur the distinction between modules and eBPF scripts in Spanish.
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
Co-authored-by: Jossemar Cordero <jossemarGT@users.noreply.github.com> Signed-off-by: Sully Martinez <47094201+SullyMA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for this contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SullyMA, it seems that the base branch is main
but it should be dev-es
. Could you change this, please?
|
I accidentally closed the pull. I meant to add a comment instead. I switched from main to dev-es. Let me know if these changes are reflected on your end. I do think Victor also went ahead and updated it. |
Describe your changes
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.