Addition of the Kubestronaut logos #471
Conversation
Signed-off-by: Christophe Sauthier <christophe.sauthier@gmail.com>
There was a problem hiding this comment.
I think it'd help to run the SVGs through autocrop which will crop the SVGs. And the PNGs should be cropped too to remove whitespace. Then you could also add link on the main README file to link to these logos.
Signed-off-by: Christophe Sauthier <christophe.sauthier@gmail.com>
|
I think I have address your concerns @cjyabraham. Thanks for your new review |
|
Some of the SVGs still have a lot of whitespace. Did you pass them all through the autocrop service? |
Signed-off-by: Christophe Sauthier <christophe.sauthier@gmail.com>
|
I did ! (I just redo it again) ! Maybe autocrop is not enough ? |
|
There's something weird going on, when I view your recent commit, it looks like this, which looks correct:
But when I view the Files changed for this PR, I see the same SVG like this with a lot more whitespace above and below: Maybe we should just merge and then see what happens?? |
|
Is this good to merge @huats @cjyabraham? |
|
Sure. I'll merge it in. |
Addition of the various Kubestronaut logos.