refactor: unpackage the functions in R/ folder, clean repo #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
force-pushed
the
ds/clean
branch
4 times, most recently
from
a2f4440
to
7250e7d
Compare
|
|
dsweber2
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Since we source this file in covid_hosp_prod, we should probably make a separate scripts/targets-exploration-common.R for the parts that are only used in exploration, so as to reduce on the overhead to understanding the prod version
dshemetov
force-pushed
the
ds/clean
branch
2 times, most recently
from
195e852
to
9282224
Compare
dsweber2
reviewed
May 13, 2024
dsweber2
reviewed
May 13, 2024
dsweber2
reviewed
May 13, 2024
* mostly moving functions and changing the way imports are handled * update ci, update renv * bring back .PHONY * remove make test-forecasters (just unskip and make test) * move forecasters into subdirectory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renv::install(".")every time you change a function