Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_issue to metadata #1413

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Add min_issue to metadata #1413

wants to merge 10 commits into from

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Mar 27, 2024

Closes #232

Summary:

Calculate and include min_issue in metadata.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@melange396
Copy link
Collaborator

I know why that test is failing, and its related to a semi-bug that i thought i had documented already (but i apparently didn't). We can work around it with a small change to the test -- i will show you tomorrow or monday.

@melange396
Copy link
Collaborator

The test failure stems from this issue i just created: #1427

You can fix this PR in the meantime by changing the way rows are created and inserted by the failing test... Right now, it creates the rows by a list comprehension and then inserts them all at once. I think that if you move the call to self._insert_rows() inside of one or both of those for loops, it should do the trick (🤞).

@nmdefries
Copy link
Contributor Author

Changed that here. Based on the previous failure, I think that's the only spot that needs to change.

@nmdefries nmdefries force-pushed the ndefries/metadata-min-issue branch from 1e29732 to f994cdf Compare May 9, 2024 22:33
@nmdefries nmdefries requested a review from melange396 May 10, 2024 23:50
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add min_issue to covidcast metadata endpoint
2 participants