Call gc during _alt forecast download function used for forecast eval pipeline
#662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookslogan
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
(If this were being used inside a fork-parallel loop run from a parent process with a bunch of stuff already in memory, we might be afraid that gc() would actually increase memory usage due to copy-on-write on OS memory pages. Checked with @nmdefries that this wasn't the case.)
dshemetov
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
forecast-evalpipeline is running out of memory. Try adding in somegc()s to free memory.Note: There are other places that could be useful to call
gc(), e.g. during scoring, during truth data fetch, but they would also impact non-forecast eval use. Given that callinggc()is a crude fix for OOM issues and that it would be nice for forecast eval to move away fromevalcast, I don't want to go deep on this change. This is just an easy intervention on a "private" function.