Merge pull request #641 from cmu-delphi/ds/evalcast-plot

bug(evalcast): remove title from labs in plots
cmu-delphi · Jun 23, 2023 · 603f551 · 603f551
2 parents 4431561 + e6a338c
commit 603f551
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/R-packages/evalcast/DESCRIPTION b/R-packages/evalcast/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: evalcast
 Type: Package
 Title: Tools For Evaluating COVID Forecasters
-Version: 0.3.1
+Version: 0.3.2
 Authors@R:
   c(
     person(given = "Daniel",
@@ -56,9 +56,9 @@ LazyData: true
 Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.2.3
 Remotes:
-    bettermc=github::gfkse/bettermc@v1.1.2,
-    zoltr=github::reichlab/zoltr,
-    covidHubUtils=github::reichlab/covidHubUtils
+    gfkse/bettermc@v1.1.2,
+    reichlab/zoltr,
+    reichlab/covidHubUtils
 Imports:
     assertthat,
     covidcast,

diff --git a/R-packages/evalcast/NEWS.md b/R-packages/evalcast/NEWS.md
@@ -1,3 +1,9 @@
+# evalcast 0.3.2
+
+- Fix DESCRIPTION remotes so `remotes` and `devtools` work
+- Fix `plot_calibration` by removing badly specified titles in the `lab` argument
+- Pin `bettermc` to the GitHub version 1.1.2 to avoid a CRAN error
+
 # evalcast 0.3.1
 
 - Added a download_signal caching folder option

diff --git a/R-packages/evalcast/R/plot_calibration.R b/R-packages/evalcast/R/plot_calibration.R
@@ -107,9 +107,7 @@ format_wedgeplot <- function(calib,
     geom_segment(aes(x = 0.5, y = 0.5, xend = 1, yend = 0), 
                  size = 0.25, color = "black") +
     labs(x = "Nominal quantile level",
-         y = "Proportion",
-         title = sprintf("%s (ahead = %s): Proportion above/below", 
-                         .data$name, .data$ahead)) +
+         y = "Proportion") +
     scale_alpha_continuous(range = c(0.5, 1)) +
     scale_size_continuous(range = c(0.5, 1)) +
     guides(alpha = FALSE, size = FALSE) +
@@ -147,9 +145,7 @@ format_traditional_calib_plot <- function(calib,
     ggplot(aes(x = .data$nominal_prob, y = .data$prop_below)) +
     geom_abline(slope = 1, intercept = 0) +
     labs(x = "Quantile level",
-         y = "Proportion",
-         title = sprintf("%s (ahead %s): Calibration", 
-                         .data$name, .data$ahead)) +
+         y = "Proportion") +
     geom_line(aes(color = .data$color, group = .data$color)) +
     scale_color_viridis_d() +
     facet_layer