Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NAN code support to Google Symptoms #993

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add NAN code support to Google Symptoms #993

wants to merge 1 commit into from

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Apr 8, 2021 •
edited

Description

Work as part #838.

Changelog

  • Add three missingness columns, default to NA for "sample_size" and "stderr" columns
  • Code the first 6 days as "insufficient data" for the 7 day average signal

Fixes

@dshemetov dshemetov mentioned this pull request Apr 8, 2021
Open
17 tasks
nmdefries
nmdefries requested changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes

_delphi_utils_python/delphi_utils/export.py Outdated Show resolved Hide resolved
google_symptoms/delphi_google_symptoms/run.py Show resolved Hide resolved
google_symptoms/delphi_google_symptoms/run.py Outdated Show resolved Hide resolved
nmdefries
nmdefries approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dshemetov
Nans google:
35c1385 
* add missing columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmdefries nmdefries nmdefries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dshemetov @nmdefries