Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NAN code support to CAN #989

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Apr 7, 2021

Description

Work as part #838. Branched off #1252, so that one should be merged first.

Changelog

  • Add three missingness columns, default to NA for "sample_size" and "stderr" columns, depending on the signal

Fixes

dshemetov and others added 2 commits October 19, 2021 11:54
* add missing columns, allow nan values through
Copy link
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dshemetov
Copy link
Contributor Author

dshemetov commented Nov 9, 2021

Bumping this PR. @krivard

@krivard
Copy link
Contributor

krivard commented Nov 10, 2021

Nothing risky until after we're clear of the JHU patch next week, which probably means after Thanksgiving 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants