Refactor doctor visits to use smoothing package #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further refactoring for the geo coding utility
Propagate geomapper changes into JHU
* use geocode utility source file and remove old static source file * update tests * update validation notebook to verify prop signals in NYC
Co-authored-by: Addison Hu <huisaddison@gmail.com>
Allow archive to be run as its own module
* change valid geo_res * change GEO_RESOLUTIOSN in run.py * update tests to use "county"
Fix JHU bug that renamed fips to county in receiving
Propagate fips -> county filename fix from JHU back into main
Co-authored-by: krivard <krivard@cs.cmu.edu>
Propagate 328 (JHU population fix and function refactor) to main
Remove cruise ships FIPS codes, 88888 and 99999, from JHU
JHU: Appease the linter
Propagate JHU linting fixes into main
Propagate safegraph repairs into main
Turn on `test_run` tests for usafacts
add pylintrc file to each indicator
Refactor safegraph to use geo utils
Refactor usafacts to use geo utils
Remove in-place modification of data frames in Safegraph processing.
Remove extraneous functions and calls from usafacts
Retain gitkeep file for JHU
Add the smoothing utility
|
blocked by #437 (EDIT: UNBLOCKED) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #435
Summary of Changes:
There are no tests written yet so I verified an example by hand for now.
Like #401: I branched this off dv-package but had to merge main in to get the most up to date geo utils, so the changes are...unreadable. Could remedy this by merging main into dv-package.