New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft of splitting NWSS signals #1946
Open
dsweber2
wants to merge
11
commits into
main
Choose a base branch
from
splittingNWSSSignals
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsweber2
changed the title
first draft of splitting signals
first draft of splitting NWSS signals
Feb 23, 2024
Minh confirmed that this runs on her machine and that the output looks reasonable. A couple of things to do before we merge this:
|
dsweber2
force-pushed
the
splittingNWSSSignals
branch
3 times, most recently
from
March 29, 2024 18:36
df5aa19
to
e86e5fa
Compare
dshemetov
approved these changes
Apr 23, 2024
dsweber2
force-pushed
the
splittingNWSSSignals
branch
from
May 13, 2024 18:42
495f183
to
07c6c90
Compare
Currently not passing because of the same update that made nssp tests fail. Once that's merged and this is rebased it will pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This splits the dataset based on the provider and normalization (not every pair is actually present), and adds the metric signals. The resulting signals are called:
Some of these can have negative values; for e.g.
ptc_15d
, the values are small enough that I expect these may actually be exponents. Still looking into why the concentration data has negative values, which are too large to make sense as exponents.Fixes
generate_weights
in the case where some weights are negative, and added a test for it