Add NCHS mortality geo aggregation at the HHS and nation levels #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krivard - ready for review! |
krivard
reviewed
Sep 14, 2021
| @@ -18,7 +19,7 @@ | |||
| from .pull import pull_nchs_mortality_data | |||
|
|
|||
|
|
|||
| def run_module(params: Dict[str, Any]): | |||
| def run_module(params: Dict[str, Any]): # pylint: disable=too-many-branches, too-many-statements | |||
There was a problem hiding this comment.
is this better than splitting it up into more-specific functions?
There was a problem hiding this comment.
Definitely not, just pushed some changes to pull out some helper methods!
Comment on lines
97
to
99
| df = df_pull.copy() | ||
| df["se"] = np.nan | ||
| df["sample_size"] = np.nan |
There was a problem hiding this comment.
this can be pulled out of the for loop
There was a problem hiding this comment.
actually it can probably be pulled out of the if block as well
Comment on lines
101
to
105
| if geo in ["hhs", "nation"]: | ||
| df = gmpr.replace_geocode( | ||
| df, "state_id", "state_code", from_col="geo_id", date_col="timestamp") | ||
| df = gmpr.replace_geocode( | ||
| df, "state_code", geo, date_col="timestamp").rename(columns={geo: "geo_id"}) |
There was a problem hiding this comment.
can we reduce some of the duplication with percent_of_expected_deaths here at all?
alexcoda
commented
Sep 17, 2021
| @@ -4,6 +4,7 @@ | |||
| disable=logging-format-interpolation, | |||
| too-many-locals, | |||
| too-many-arguments, | |||
| fixme, | |||
There was a problem hiding this comment.
Added this for a TODO I left in the code. Let me know if this is something we'd want to keep consistent across all indicators and I can add it to others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add NCHS mortality geo aggregation at the HHS and nation levels.
Note that because one of the columns being aggregated is a percentage, we're doing a weighted sum with the geomapper
Also there are some pylint disables for too many branches, this is because of the slight difference in logic for handling the percentage vs. count variables. This could be refactored later for the entire run.py function, but is not in scope for this change.
Fixes