Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Disable TensorFlow tests to allow Travis macOS builds to succeed. #1449

Merged
merged 1 commit into from Jul 3, 2018
Merged

Disable TensorFlow tests to allow Travis macOS builds to succeed. #1449

merged 1 commit into from Jul 3, 2018

Conversation

mbutrovich
Copy link
Contributor

Workaround for #1448. This change should be reverted once the tensorflow package is updated with Python 3.7 compatibility.

@mbutrovich mbutrovich self-assigned this Jul 2, 2018
@saatviks
Copy link
Contributor

saatviks commented Jul 2, 2018 •
edited

Thanks for pointing out the problem @mbutrovich
An alternative as described here would be to install directly as pip3 install https://storage.googleapis.com/tensorflow/mac/cpu/tensorflow-1.4.0-py3-none-any.whl.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 76.467% when pulling fbb86f9 on mbutrovich:disable_tf_test into 6cc5559 on cmu-db:master.

@saatviks
Copy link
Contributor

saatviks commented Jul 2, 2018

Seems like the solution in #1450 also doesnt work as detailed in this issue here. Best to go ahead with this fix of disabling tensorflow tests. I'm closing mine.
Also notifying @malin1993ml that we are doing this.

saatviks
saatviks approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@saatviks saatviks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tli2 tli2 merged commit c949481 into cmu-db:master Jul 3, 2018
@mbutrovich mbutrovich deleted the disable_tf_test branch July 3, 2018 14:56
mtunique pushed a commit to mtunique/peloton that referenced this pull request Apr 16, 2019
@mbutrovich @tli2
Disable TensorFlow tests to allow Travis macOS builds to succeed. (cm…
159faed 
…u-db#1449)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saatviks saatviks saatviks approved these changes

@pervazea pervazea pervazea approved these changes

Assignees

@mbutrovich mbutrovich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mbutrovich @saatviks @coveralls @pervazea @tli2