Fix MRE automatic trashing and nade box trashing #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mre runtimes if spawned on mob but no space Add same auto throwaway on dropped signal to grenade box
github-actions
bot
added
Feature
harryob
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes runtimes with MREs if they spawn on someone that doesn't have space for them (causing 2 extra qdels than needed), fixes MREs getting thrown away when you aren't dropping them on the ground, and changes the behavior of nade_box to not automatically qdel when it is emptied but instead now has the same behavior as a MRE without food being dropped on the ground.
Explain why it's good for the game
Fixes
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
馃啈 Drathek
add: Nade boxes now have the same throw away logic when dropped to the ground instead of in update_icon when empty.
fix: Fixed MREs getting thrown away if you don't drop them to the ground.
fix: Fixed MREs throwing runtimes if spawned on a person that doesn't have space for the MRE.
/:cl: