Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wo clothing surplus vendor to the more modern distress mode. #6256

Closed
wants to merge 1 commit into from

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented May 7, 2024

About the pull request

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

馃啈
balance: update wo clothing surplus vendor to the more modern distress mode.
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label May 7, 2024
@Huffie56 Huffie56 marked this pull request as ready for review May 7, 2024 19:16
@Huffie56 Huffie56 marked this pull request as draft May 7, 2024 19:17
@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label May 7, 2024
@Huffie56 Huffie56 marked this pull request as ready for review May 7, 2024 19:19
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just simply copy pasting the inventory to these vendors is not going to work - the only edits I see made is removal of the drop pouch, and an increased scaling of the shoulder holster. For example, the headsets are just common channel (when it used to provide each squad's) and you're providing telephone packs when there are no telephones to use.

Also worth mentioning there are 2 more of these vendors on WO than there are on the Almayer.

Additionally, the PR template should be filled out, not ignored.

@Drulikar Drulikar removed the Code Improvement Make the code longer label May 14, 2024
@Drulikar Drulikar marked this pull request as draft May 14, 2024 08:35
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label May 15, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Drulikar
Copy link
Contributor

Single argument round should be floor now.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 23, 2024
@Huffie56
Copy link
Contributor Author

it's been a while since i was on this PR and with the var name change and drak comment i think it's better to start fresh with a new PR.

@Huffie56 Huffie56 closed this May 25, 2024
@Huffie56 Huffie56 deleted the wo_vendor branch May 26, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Merge Conflict PR can't be merged because it touched too much code Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants