Fixes light attachments setting and add pref for ammo counter #6251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2024 10:51
github-actions
bot
added
Quality of Life
|
I don't think ammo counter change is needed unless you make it a setting. |
Sure thing. |
|
You can toggle it now. |
Drulikar
requested changes
May 13, 2024
Drulikar
changed the title
Drulikar
requested changes
May 15, 2024
There was a problem hiding this comment.
As mentioned on discord:
- This would be better as a player preference rather than something you need to set per weapon IMO
- I have no idea where verb desc even gets displayed for us, so conveying the < 15 bullet information needs to also be somewhere else; or just make it a different option for the pref (e.g. every bullet, every 5 bullets unless low, every 5 bullets)
- Additionally, you should mention this only applies to semi fire (e.g. make the preference called semi-auto ammo counter - because of note this doesn't work for automatic but I think that's fine)
added 3 commits
May 15, 2024 07:11
Drulikar
requested changes
May 17, 2024
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Drulikar
requested changes
May 19, 2024
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Drulikar
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Closes #6238, also made the ammo display less spammy.
🆑
qol: Toggleable ammo counter, can now cycle between displaying every fifth or single bullet.
fix: Light attachments will no longer automatically turn on when the weapon is equipped from suit storage
/:cl: