ARC features

[Diegoflores31]

About the pull request

• Adds support for custom access requirements for the driving seat ( something like a key )
• increases the ARC passeger amount to 4
• Adds Command Access lock for the ARC driver.
• Adds a pamphlet crate with driving skill on requisitions.

Explain why it's good for the game

-Adds more flexibility to the ARC in cases where there may not be 2 SOs available or they preffer a different driver. to focus more on Commanding inside of the ARC.
-Prevents future funnsies from happening . you now require a Access to drive the ARC meaning . only people granted access by command may drive the ARC. (( can be changed to ACCESS_CREWMAN in the future or even create custom "keys"))
-adds one more passenger to the ARC so marines can retrieve the 3 corpses inside or someone can enter to talk .. etc . the extra slot is meant for a passerby therefore no seat will be added.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: ARC now has a Generic Command access lock for the driver seat
add: Adds a a pamplet crate containing 1 pamplet for the ARC for 5000$
balance: increased ARC capacity to 4
code: Added support for Access locks on Vehicles
/:cl:

[Zonespace27]

add: Adds a a pamplet crate containing 1 pamplet for the ARC for 5000$

I am entirely against this.

[Diegoflores31]

add: Adds a a pamplet crate containing 1 pamplet for the ARC for 5000$

I am entirely against this.

That was added specifically to go along the ID lock on the ARC . there wont be any ARC hijack or that kind of stuff unless command specifically allows it . also opens grounds for other command/support to drive the ARC under specific circumstances winout having to give every command member a VC skill

[Skatuk]

Can you make the key being able to be stored alongside the ID slot or inside the ID?

[Zonespace27]

code doc

[Zonespace27]

That was added specifically to go along the ID lock on the ARC . there wont be any ARC hijack or that kind of stuff unless command specifically allows it . also opens grounds for other command/support to drive the ARC under specific circumstances winout having to give every command member a VC skill

Here are the issues I see with this:

• It's inevitably going to lead to people buying this to fuck around with the van / ARC, which is a lot of wasted cash.
• Having someone who isn't an SO drive the ARC isn't worth 5k req points.
• Outside of the (usually dead) IOs¹, the only marines who have ACCESS_MARINE_COMMAND are the ones not allowed to deploy (MP, CMP, SEA, etc.).
• I still believe this goes against my core design principle of it being "the command vehicle". I've used the ARC a handful of times in an actual round, and I haven't had a problem driving the ARC and still being a member of command at the same time.

My opinion isn't changing, please remove the pamphlet from req.

Footnotes

1. I also don't want IOs to become the "oh command buy an arc and req spend 5k on a pamphlet so i can drive pleasepleaseplease" role. ↩

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself