Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bonus projectiles not hitting #6249

Closed
wants to merge 4 commits into from

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented May 6, 2024

About the pull request

#1608 added random speed variance to projectiles to make them look less beamy however some projectiles and most notably buckshot requires all projectiles to be of equal speed because the main projectile causes a stun which will make the rest of the projectiles miss if they don't hit first.

Potentially fixes #3053 and #1764

Explain why it's good for the game

Fixes a bug

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

馃啈
fix: Fixes bonus projectiles not hitting sometimes
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label May 6, 2024
@fira
Copy link
Member

fira commented May 11, 2024

Well this should work, but I think a better way to go about this would be to add a delay to dodging by lying down, it'd also address similar issues with explosion sharpnel

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try what is proposed by Fira, or indicate that you would still prefer this method.

@Drulikar Drulikar marked this pull request as draft May 14, 2024 07:41
@Git-Nivrak Git-Nivrak marked this pull request as ready for review May 14, 2024 08:26
@Drulikar Drulikar marked this pull request as draft May 14, 2024 09:53
@Git-Nivrak Git-Nivrak marked this pull request as ready for review May 14, 2024 09:58
@Drulikar
Copy link
Contributor

I'm not really finding any change with this PR, but maybe I'm not understanding the issue.

@Drulikar Drulikar marked this pull request as draft May 14, 2024 11:01
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 22, 2024
@github-actions github-actions bot closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buckshot Projectiles Not Hitting Targets Simultaneously
3 participants