Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validates sql in unit testing #6211

Closed
wants to merge 11 commits into from
Closed

Conversation

harryob
Copy link
Member

@harryob harryob commented Apr 29, 2024

no player facing etc

@github-actions github-actions bot added Github We don't really know what else this belongs to Missing Changelog Maintainers always document their changes. labels Apr 29, 2024
@harryob harryob removed the Missing Changelog Maintainers always document their changes. label Apr 29, 2024
@Zonespace27 Zonespace27 added the Unit Tests Keep the game broken, forcefully. label Apr 30, 2024
@fira
Copy link
Member

fira commented May 3, 2024

Awesome idea!
That's all there is to it, RUST_BAKCTRACE provides neccessary output?

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 11, 2024
@github-actions github-actions bot closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github We don't really know what else this belongs to Stale beg a maintainer to review your PR Unit Tests Keep the game broken, forcefully.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants