Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an animation when missing melee attacks #6199

Closed
wants to merge 1 commit into from

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Apr 28, 2024

About the pull request

Adds an animation (similar to xeno swipe when missing slashes) when missing melee attacks with items.

Explain why it's good for the game

More indicative to the player, Rather than thinking their clicks get "eaten" they will be able to see when they miss and when the attack delay is in effect

Testing Photographs and Procedure

2024-04-28.09-18-46.mp4

Changelog

馃啈
add: Added an animation when missing melee attacks with items
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Apr 28, 2024
@fira
Copy link
Member

fira commented May 2, 2024

I dunno... I think this could be misleading in its own way too

Maybe the animation could be changed so you can tell both apart?

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 10, 2024
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label May 13, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on discord, try doing what Fira suggested and tweak the animation for a miss. Even just a different tween may be enough.

@Drulikar Drulikar marked this pull request as draft May 13, 2024 04:31
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 21, 2024
@github-actions github-actions bot closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants