Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Jinja whitespace control in Babel mapping #1130

Merged
merged 2 commits into from Feb 8, 2021
Merged

Set up Jinja whitespace control in Babel mapping #1130

merged 2 commits into from Feb 8, 2021

Conversation

andreyv
Copy link
Member

@andreyv andreyv commented Aug 20, 2019

The lstrip_blocks environment parameter affects Jinja parsing mode, see pallets/jinja#748. Hence we need to use the same whitespace control parameters as in the actual CMS code.

Fixes #1096.

I also changed the mapping file to use the conventional INI file syntax for better source highlighting.


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #1130 (7c5e31e) into master (7f77a52) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
+ Coverage   63.50%   63.55%   +0.05%     
==========================================
  Files         232      232              
  Lines       17028    17028              
==========================================
+ Hits        10813    10822       +9     
+ Misses       6215     6206       -9     
Flag Coverage Δ
functionaltests 47.46% <ø> (+0.06%) ⬆️
unittests 44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cms/service/ProxyService.py 65.62% <0.00%> (-1.57%) ⬇️
cms/db/filecacher.py 77.41% <0.00%> (-0.65%) ⬇️
cms/db/base.py 87.12% <0.00%> (ø)
cms/grading/Job.py 90.90% <0.00%> (+0.45%) ⬆️
cms/service/EvaluationService.py 73.13% <0.00%> (+0.49%) ⬆️
cms/service/workerpool.py 66.11% <0.00%> (+0.55%) ⬆️
cms/server/admin/handlers/base.py 70.62% <0.00%> (+0.66%) ⬆️
cms/server/contest/handlers/contest.py 87.37% <0.00%> (+0.97%) ⬆️
cms/io/triggeredservice.py 87.87% <0.00%> (+1.01%) ⬆️
cms/server/contest/handlers/tasksubmission.py 48.63% <0.00%> (+1.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f77a52...7c5e31e. Read the comment docs.

The lstrip_blocks environment parameter affects Jinja parsing
mode, see pallets/jinja#748. Hence we need to use the same
whitespace control parameters as in the actual CMS code.

Fixes #1096.
@andreyv andreyv merged commit ea5542e into cms-dev:master Feb 8, 2021
@andreyv andreyv deleted the babel-mapping branch February 8, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cannot extract some messages after db8a3db9ca67983b6f28652162407ceca92c19d1
1 participant