This repository has been archived by the owner on May 19, 2022. It is now read-only.
new env _FASD_ADD_MAX for max args to process in --add/--proc #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an example where '*' expanded to 17k elts, fasd used 10s before giving the next bash prompt. This change cuts the list down to the last _FASD_ADD_MAX arguments (defaults to 2000).
dsedivec
reviewed
Sep 2, 2020
|
|
||
| # possibly too many elements: | ||
| if [ $# -gt $_FASD_ADD_MAX ]; then | ||
| shift $(( $# - _FASD_ADD_MAX )) |
There was a problem hiding this comment.
FWIW I found it surprising that this removed the first N excess arguments rather than the last N arguments. That said, I don't know a better way to do this in POSIX shell that isn't some big nasty loop. (I hit the same problem this PR tries to address. I'm now trying to migrate away from fasd to something else.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an example where '*' expanded to 17k elts, fasd used 10s before
giving the next bash prompt. This change cuts the list down to the
last _FASD_ADD_MAX arguments (defaults to 2000).