-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add kyverno patch config #564
base: main
Are you sure you want to change the base?
Conversation
@dixudx please take a look based on kyverno/pkg/engine, I made some changes, because the opentelemetry package versions is conflict between kyverno and clusternet ( I cannot use kyverno package in clusternet project ):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just import module github.com/kyverno/kyverno
and use it, instead of adding files in pkg/kyverno
?
It seems many files under folder pkg/kyverno
are directly copied from package github.com/kyverno/kyverno
.
I try to use it directly, but the opentelemetry version of clusternet is conflict with kyverno. finally i chose the latter. |
yes, many files are copied, but i made some changes
Is it better to put code in pkg/kyverno into annother project? |
I'd prefer to upgrade the dependencies versions, where
Try to use a lower version kyverno to see whether it works with current dependencies. Or try other ways to solve the module conflict issues. The main point is that we should avoid copying codes into clusternet. Using modules are more wise, which makes us easy to maintain, upgrade, etc. |
Thank you for the advice, I will try a lower version kyverno. |
@abstractmj I've tried and found that using |
@abstractmj Do you have time to modify this feature? I'd like to get it merged into next release v0.15.0. |
@dixudx Yes, I'll modify this feature in this week; |
feature: add kyverno style globalization and localization Signed-off-by: abstractmj <abstractmj@qq.com>
telemetry module conflicts are solved by using kyverno v1.7.4; but I still found conflicts of module gnostic and module client-go when I was compiling the code; so I have to fork the kyverno to my own repository, please look at this commit @dixudx https://github.com/abstractmj/kyverno/commits/v1.7.4-upgrade-gnostic |
@abstractmj I've created a commit based on latest |
@dixudx I've tried this, go mod tidy works fine, but errors occurs when compiling the code; this is why I have to fork the kyverno code /data/pkg/mod/github.com/kyverno/kyverno@v1.7.4/pkg/dclient/discovery.go:65:9: cannot use c.cachedClient.OpenAPISchema() (value of type *"github.com/google/gnostic/openapiv2".Document) as type *"github.com/googleapis/gnostic/openapiv2".Document in return statement the module gnostic/openapiv2 is different between client-go v0.23.5 and v0.24.2 |
@abstractmj Would you please create a new branch with this commit and your kyverno integration codes? We could have a collaboration on that branch. |
@dixudx okay |
@abstractmj After investigating, the blocking part is the dependency Currently all k8s dependencies in Clusternet use module /hold this feature until we bump k8s dependencies in Clusternet to |
@abstractmj Current the k8s dependencies in main branch have been upgraded to v1.26. You can rebase this PR and move forward. Thanks. |
great to hear that. I will move forward |
feature: add kyverno style globalization and localization
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #551
Currently blocked by #611 to help solve the renaming module
github.com/google/gnostic
.Special notes for your reviewer: