Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster registration workflow doc #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanielXLee
Copy link
Contributor

What type of PR is this?

New doc

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@dixudx dixudx added the kind/documentation Improvements or additions to documentation label Sep 6, 2021
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration.md Outdated Show resolved Hide resolved
@dixudx dixudx changed the title Add cluster registry workflow architecture add doc on cluster registration workflow Sep 8, 2021
@DanielXLee DanielXLee changed the title add doc on cluster registration workflow Cluster registration workflow doc Sep 8, 2021
@DanielXLee
Copy link
Contributor Author

@dixudx @yiwei-C updated with your comments, review again.

Copy link
Contributor

@yiwei-C yiwei-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few minor issues I missed. Could you modify these as well? Thank you.

docs/architecture/cluster-registration-workflow.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration-workflow.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration-workflow.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration-workflow.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration-workflow.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration-workflow.md Outdated Show resolved Hide resolved
docs/architecture/cluster-registration-workflow.md Outdated Show resolved Hide resolved
@DanielXLee
Copy link
Contributor Author

updated @yiwei-C

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2021

Codecov Report

Merging #106 (bd7009c) into main (86ee610) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   10.55%   10.55%           
=======================================
  Files          39       39           
  Lines        4254     4254           
=======================================
  Hits          449      449           
  Misses       3773     3773           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ee610...bd7009c. Read the comment docs.

Signed-off-by: Xin Li <lixin8611@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants