Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer promt for http port #619

Merged
merged 4 commits into from
May 5, 2024

Conversation

Danielv123
Copy link
Member

Resolves #564

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.82%. Comparing base (79c1a2d) to head (78a9f73).
Report is 13 commits behind head on master.

❗ Current head 78a9f73 differs from pull request most recent head 131e45e. Consider uploading reports for the commit 131e45e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
- Coverage   76.83%   76.82%   -0.01%     
==========================================
  Files         106      106              
  Lines       10049    10059      +10     
  Branches     1658     1664       +6     
==========================================
+ Hits         7721     7728       +7     
- Misses       1796     1797       +1     
- Partials      532      534       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tests are skipped because they are really slow and fail in CI
Copy link
Collaborator

@Cooldude2606 Cooldude2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. Although are the tests meant to be skipped?

@Danielv123
Copy link
Member Author

Tests work fine locally but are slow. They fail entirely in CI for what seems like random reasons. I just disabled them, leaving them there in case anyone wants to mess with it later.

@Cooldude2606 Cooldude2606 merged commit 54f56d0 into clusterio:master May 5, 2024
3 checks passed
@Danielv123 Danielv123 deleted the prompt-for-http-port branch May 12, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prompt for controller.http_port during install.
2 participants