Ignore error when closing an already closed serial connection #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An OSError would be raised when reader and writer threads were concurrently closing the serial connection. One of them would close an already closed connection. Ideally this would be synchronized so we'd be able to detect an issue closing the connection. In this case a global resource in the system may be broken rendering the system un-usable. For now we just ignore any issues while closing, not taking a potential later use of the device into account.
Need evidence that this exact code is executed.
clssn
force-pushed
the
bugfix/fail-on-concurrent-serial-close
branch
from
886e0fe
to
bcb633d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An OSError would be raised when reader and writer threads were concurrently closing the serial connection. One of them would close an already closed connection.
Ideally this would be synchronized so we'd be able to detect an issue closing the connection. In this case a global resource in the system may be broken rendering the system un-usable.
For now we just ignore any issues while closing, not taking a potential later use of the device into account.