Simplify reading from the device, ignoring end-of-line characters #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discard EOL characters, then it's possible to read byte wise not to miss a notification. Remove all EOL related code from the NumatoUsbGpio class.
This was
linked to
issues
Mar 10, 2024
clssn
changed the title
|
With the goal to further simplify the code, this commit applies the single responsibility principle to the query method. This is done by removing the validation extra-functionality into a read_response method which is now called after the query. The read_response method accepts the expected response as optional argument so that the response can be validated in a uniform way. Additionally resolved several issues reported by static code analysis.
Also adapt and improve tests and fix pylint findings.
Was mistakenly pyline.
clssn
force-pushed
the
feature/34-simplify-reading
branch
from
1f30335
to
96482b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading from the various device variants got overly complicated with all the variants.
It just occurred to me that the EOL sequences don't play any role, they are just there for better readability in a screen session with a human.
Remove EOL characters during low-level reading
Remove any other EOL related code except the \r in queries
Unify queries so to always read until the next prompt character (>)
Validate port lengths in port length related queries